this post was submitted on 09 Sep 2023
1052 points (97.2% liked)
Programmer Humor
32558 readers
1007 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Solution: Code Style Guidelines doc that the team agrees on. A checkbox in the PR template that affirms that code is compliant with the guidelines.
This way it’s not personal, it’s a rule that everyone should follow as a shared standard.
Use cicd tooling to enforce it not human eyes
This sadly sounds like one of the projects on my teamat the moment and it's horrifying.
One guy working on it, I'm really the only reviewer. Code is all stuff like this. Variables named j1 through j20, dozens and dozens of nearly identical functions with tons of brute force, copy-pasted code, etc. Works well enough but it's just horrifying to try to read and review.
Edit:. Just remembered, he had all these grouped functions passing (and sometimes returning) 60+ identical variables that didn't need to be local because he refused to use class vars, etc.
He's gotten a lot better about this stuff in the last year though
You know, as an amateur with massive impostor syndrome who's probably going to be applying for jobs soon, this comment and those like it give me strength.
Stop right there. This idea does not exist in a workplace setting