this post was submitted on 29 Oct 2024
97 points (97.1% liked)

Technology

59422 readers
2897 users here now

This is a most excellent place for technology news and articles.


Our Rules


  1. Follow the lemmy.world rules.
  2. Only tech related content.
  3. Be excellent to each another!
  4. Mod approved content bots can post up to 10 articles per day.
  5. Threads asking for personal tech support may be deleted.
  6. Politics threads may be removed.
  7. No memes allowed as posts, OK to post as comments.
  8. Only approved bots from the list below, to ask if your bot can be added please contact us.
  9. Check for duplicates before posting, duplicates may be removed

Approved Bots


founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] drre@feddit.org 9 points 2 weeks ago (1 children)

maybe I'm missing something but wouldn't this show up in a diff before pushing?

[–] breadsmasher@lemmy.world 11 points 2 weeks ago (1 children)

The culprit: name-hash collisions. With files like changelog.md and changelog.json, Git found all kinds of differences with each commit even though there often were none, which gradually added 173GB of unnecessary bloat. However, the changelogs were in completely different packages. The algorithm checked only the last 16 characters of the path, so package differences were not considered.

[–] drre@feddit.org 11 points 2 weeks ago

thanks for the reply, but i think i got that. from the linked article:

For example, if you changed repo/packages/foo/CHANGELOG.json, when git was getting ready to do the push, it was generating a diff against repo/packages/bar/CHANGELOG.json! This meant we were in many occasions just pushing the entire file again and again, which could be 10s of MBs per file in some cases, and you can imagine in a repo our size, how that would be a problem.

but wouldn't these erroneous diffs not show up in git diff? it seems that they were pushing (maybe automatically?)without inspecting the diffs first