this post was submitted on 11 Dec 2023
32 points (79.6% liked)

JavaScript

1700 readers
47 users here now

founded 1 year ago
MODERATORS
erlingur@programming.dev
Ategon@programming.dev
nick@programming.dev
32
Stop nesting ternaries in JavaScript (www.sonarsource.com)
submitted 9 months ago by philnash@programming.dev to c/javascript@programming.dev
34 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] kassuro@feddit.de 22 points 9 months ago (4 children)

I often have the pleasure of refactoring this mess. And sometimes it's not just 2 ternaries but like 4 or 5 thrown together. It took like half an hour to even understand what was going on. If you do this, you are just an evil person...

So I totally support this. Stop this shit...

[–] coloredgrayscale@programming.dev 10 points 9 months ago (1 children)

pleasure of refactoring this mess took half an hour to understand

If you can use any of the jetBrains IDE it can rewrite it to if/else with a few clicks (or [alt] +[return])

[–] kassuro@feddit.de 2 points 9 months ago

Ah that would be helpful. Gotta try that the next time I encounter such a monstrosity.

[–] folkrav@lemmy.ca 8 points 9 months ago (1 children)

This shit always leaves me wondering who even writes this crap. The answer is more often than not a junior that just discovered code golf thinking he’s oh so clever. You learn to appreciate boring code, with experience…

[–] kassuro@feddit.de 5 points 9 months ago

Totally agree with you. I'm always an advocate for boring and easy to understand code.

I really don't need an extra layer of complexity just so someone can save a line or two.

[–] SatouKazuma@lemmy.world 7 points 9 months ago

So I'm pretty sure nested ternaries violate one of the Geneva Conventions' optional protocols.

[–] Lmaydev@programming.dev 1 points 9 months ago

Perfect job for ChatGPT.