this post was submitted on 15 Jun 2024
721 points (98.3% liked)

Programmer Humor

32361 readers
294 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] yum@lemmy.eco.br 4 points 4 months ago (1 children)

Should I bother using just classes or can I keep making ids?

[–] NiPfi@lemmy.world 2 points 4 months ago (1 children)

Tbh, I think for unique elements that's a valid approach. It also enables easier element selection in automated e2e testing

[–] dan@upvote.au 4 points 4 months ago* (last edited 4 months ago) (1 children)

In E2E tests you should ideally be finding elements using labels or ARIA roles. The point of an E2E test is to use the app in the same way a user would, and users don't look for elements by class name or ID, and definitely not by data-testid.

The more your test deviates from how real users use the system, the more likely it is that the test will break even though the actual user experience is fine, or vice versa.

This is encouraged by Testing Library and related libraries like React Testing Library. Those are for unit and integration tests though, not E2E tests. I'm not as familiar with the popular E2E testing frameworks these days (we use an internally developed one at work).

[–] NiPfi@lemmy.world 1 points 4 months ago

I agree, but our tester is a bit lazy I suppose