1
Looking for drunkenslug invite
(feddit.it)
Bad advice. Early return is way easier to parse and comprehend.
if (p1)
{
if(!p2)
{
if(p3 || !p4)
{
*pOut = 10;
}
}
}
vs
if(!p1) return;
if(p2) return;
if(!p3 && p4) return;
*pOut = 10;
Early out makes the error conditions explicit, which is what one is interested in 90% of the time. After the last if you know that all of the above conditions are false, so you don’t need to keep them in your head.
And this is just a silly example with 3 predicates, imagine how a full function with lots of state looks. You would need to keep the entire decision tree in your head at all times. That’s the opposite of maintainable.
Use uBlock Origin. Not AdBlock, not AdBlock Plus, not any other crapware. Looking at AdBlock website they have a blurb about only keeping anonymised data and never selling it and yada yada yada, because it goes against their company ethics.
Company ethics. AdBlock is owned by a company. A for-profit entity. How do you think they make their money? Either they sell the data they have gathered (why does an ad blocking extension need to gather user data?) or they have agreements with ad companies.
Compare the websites of AdBlock and uBlock Origin. The first thing on uBlock Origin website is a link to the publicly available source code. That’s trustworthy. AdBlock’s website has a handpicked list of 5 star reviews.
TL; DR: please switch to uBlock Origin and ditch AdBlock, they (the company behind AdBlock) likely have agreements with advertisers (including Google and YouTube) to make money. Your data is being harvested by using AdBlock. You cannot look at the code for AdBlock. AdBlock is not trustworthy.