this post was submitted on 14 Nov 2023
733 points (97.0% liked)

Programmer Humor

25512 readers
2202 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
 

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

you are viewing a single comment's thread
view the rest of the comments
[–] Blackthorn@programming.dev 1 points 2 years ago (5 children)

Probably unpopular opinion, but peer reviews are overrated. If coders are good AND know the project, the only thing you can do in a PR is nitpicking. They are more useful for open source collaborators because you want to double-check their code fits with the current architecture. But people here are reacting as if peer reviews could actually spot bugs that tests can't catch. That happens rarely unless the contributor is junion/not good.

[–] the_artic_one@programming.dev 1 points 2 years ago (1 children)

If coders are good AND know the project

Those are some pretty big ifs.

[–] Blackthorn@programming.dev 1 points 2 years ago

Code review can't fix incompence though. I lost count of how many times my boss told me "review that PR well because X is not very good". Also my point is that they are overrated, not that they are useless.

load more comments (3 replies)