this post was submitted on 21 Jun 2023
53 points (100.0% liked)
Technology
37630 readers
274 users here now
A nice place to discuss rumors, happenings, innovations, and challenges in the technology sphere. We also welcome discussions on the intersections of technology and society. If it’s technological news or discussion of technology, it probably belongs here.
Remember the overriding ethos on Beehaw: Be(e) Nice. Each user you encounter here is a person, and should be treated with kindness (even if they’re wrong, or use a Linux distro you don’t like). Personal attacks will not be tolerated.
Subcommunities on Beehaw:
This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I notice a few UI-related things:
(Still need to test pinned messages being moved when sorted by new) (I should post this in there, actually, I guess)
Is there a reason you consider passwords longer than 60 characters an issue, or does the backend reject such passwords? In my experience, there should be no upper bound on password length except maybe in the order of request size being too large (say a password that is a several kilobytes).
The 60 character limit is not a problem imo, the problem is that they are truncated at 60 but the UI doesn't tell you, this results in some problems.
Oh yea, that is a huge issue.
Some password encryption methods has max characters length. For example Bcrypt has 72 max length. This is mostly to avoid taking too much time encrypting user input.
If there's no limit someone can technically froze the server by inputting large password (not because the request is big, but encryption process is exponentially takes more CPU process the longer it is)
Having only ever implemented PBKDF2 this is a good insight as well. This limitation does not seem to be an issue with more modern hashing algorithms, but I can see where limiting the size to a reasonable amount for purposes of having an upper bound on performance would be needed.
Passwords "should" be hashed anyway, so I don't understand why there's a limit. Are they actually being stored as plaintext in a VARCHAR(60) column in the database? Please tell me that's not happening.
Just checked my own Lemmy postgres database, it's a 12 round Bcrypt 2b hash.
Is it possible if you can submit that comment as a post in enterprise.lemmy.ml cause that way the devs could see your thoughts? Or you could submit it as a ticket in the issues tab in lemmy-ui I guess if that's more convient